agritheory / test_utils

Common Test Utilities and Fixtures for AgriTheory Projects
2 stars 3 forks source link

Calculate customization hash ignores HRSM customizations #31

Closed agritheory closed 1 month ago

agritheory commented 2 months ago

17 Won't detect changes to HRMS customizations without some help.

I propose we abstract the HRMS lookup into a separate function so we can incorporate it into the workflow.

We can check if HRMS is installed like this:

try: 
    import hrms
    hrms_installed = True
except ModuleNotFoundError as e:
    hrms_installed = False
MyuddinKhatri commented 2 months ago

17 Won't detect changes to HRMS customizations without some help.

I propose we abstract the HRMS lookup into a separate function so we can incorporate it into the workflow.

We can check if HRMS is installed like this:

try: 
  import hrms
  hrms_installed = True
except ModuleNotFoundError as e:
  hrms_installed = False

@agritheory rather than doing this as we already have a list of installed apps, customize.py-L16 can we use this directly?

agritheory commented 2 months ago

@MyuddinKhatri Yeah, that should work just fine

MyuddinKhatri commented 1 month ago

@agritheory Can this be marked as completed.