search

agritheory / test_utils

Common Test Utilities and Fixtures for AgriTheory Projects
4 stars 4 forks source link

fix: add mypy hook with default args #62

Closed Alchez closed 4 months ago

Alchez commented 4 months ago

Closes #56.

@agritheory This change definitely seems opinionated since the fixes will be applied per-repository anyway. I guess it could still be useful to compile as an internal config though.

agritheory commented 4 months ago

@Alchez What part seems opinionated? Ignore missing imports? I think that's the right trade off but I agree it's a bid of a code smell.

Alchez commented 4 months ago

@Alchez What part seems opinionated? Ignore missing imports? I think that's the right trade off but I agree it's a bid of a code smell.

@agritheory Yeah basically we could add the mypy hook directly in each repo's pre-commit, but if we're making the ignore missing imports argument standard, then this is better.