agro6162 / talkmyphone

Automatically exported from code.google.com/p/talkmyphone
0 stars 0 forks source link

Criteria for finding contact phone should be improved. #32

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
If you try to send a sms to a contact using his name or part of his name, 
TalkMyPhone will try to find his cellphone number using 2 criterias:
  * it will look for phone numbers in the category cellphone
  * as the contacts list is not error prone, it will look for phone numbers matching a pattern.

What steps will reproduce the problem?

1 - try to send a sms to a foreigner contact that has a phone number not 
registered as cellphone type
2 - TalkMyPhone will reply: no match.

What is the expected output? What do you see instead?

TalkMyPhone should find the contact number and send him a sms.

Please use labels and text to provide additional information.

Proposed fix: 
  * The regexp for matching cellphones should be removed as one will never succed in writing a regexp that can match every cellphone numbers in an international style. Letting access to this regexp in the UI is not a good idea: users don't want to type regexps in order to find phone numbers. 
  * Instead, the lookup should encourage the users to clean their contacts and put the right type in front of every numbers. Here is how phone numbers could be searched:
    * look for phone numbers in the category cellphone
    * if there is no match for cellphones, but there is one match in another category, try this number
    * otherwise, return every available phone numbers and let the user make his choice (with a message like: you can improve TalkMyPhone recognition of phone numbers by typing them correctly)

Original issue reported on code.google.com by chm.duquesne on 19 Sep 2010 at 8:20

GoogleCodeExporter commented 9 years ago
The error message is not very clear. In my sentence, typing a phone number 
meant "selecting the right type", as in "variables typing" when programming.

Original comment by chm.duquesne on 19 Sep 2010 at 8:23

GoogleCodeExporter commented 9 years ago
I have some contacts with several cellphone numbers and when I enter 
"sms:Michel DUPONT:message" it displays "Specify more details: Michel DUPONT - 
06xxx Michel DUPONT 06yyy". It is a good idea to do this then after I can 
select the right number and enter "sms:06yyy:message"
I think that it could be interesting to use a similiar method  for implementing 
a search command that can find every contact that match partially the search. 
Something like "search:Michel" that will provide :"Michel Dupont - 06xxx Michel 
Dupont - 06yyy Michel DURAND - 06zzz"

Original comment by sb.musi...@gmail.com on 21 Sep 2010 at 1:06

GoogleCodeExporter commented 9 years ago
I've had a new command contact:[search pattern] that provide all phone numbers, 
e-mails and postal address for contacts matching to the searched pattern.

It should be merge into the main release at the end of the week.

Original comment by Florent....@gmail.com on 21 Sep 2010 at 2:44

GoogleCodeExporter commented 9 years ago

Original comment by Florent....@gmail.com on 30 Sep 2010 at 7:54

GoogleCodeExporter commented 9 years ago

Original comment by chm.duquesne on 6 Oct 2010 at 1:28