agro6162 / talkmyphone

Automatically exported from code.google.com/p/talkmyphone
0 stars 0 forks source link

GPS never turns off #46

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Send 'where' to the phone.
2. You get the location URL.
3. Send 'stop' and it never stops.

What is the expected output? What do you see instead?
The location messages should stop and the GPS turned off.

What version of the product are you using? On what operating system?
Android 2.2 (CM 6 nightly) on Google Nexus One.

Please provide any additional information below.
Using one account to send to another.

Original issue reported on code.google.com by paal.nil...@gmail.com on 26 Sep 2010 at 10:38

GoogleCodeExporter commented 9 years ago
I can't reproduce it. Providing the output of "adb logcat" would help to debug 
this one.

Original comment by chm.duquesne on 27 Sep 2010 at 8:48

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
The same bug exists for me on the Nexus One.

Original comment by evanvhan...@gmail.com on 6 Oct 2010 at 7:09

GoogleCodeExporter commented 9 years ago
Same here.
Can't stop it.

Original comment by maca...@gmail.com on 7 Oct 2010 at 3:12

GoogleCodeExporter commented 9 years ago
I noticed that in addition to the location messages showing up on my desktop, 
they are being received by Talk on the phone.  The messages seem to be coming 
into Talk faster than the phone can handle.  Even after killing talkmyphone, 
the messages continue to arrive until Talk finally catches up.  I wonder if a 
DOS is being created preventing the stop command from being processed.  There 
isn't any need to the location message updating so frequently.

Original comment by evanvhan...@gmail.com on 7 Oct 2010 at 3:19

GoogleCodeExporter commented 9 years ago
There is no DOS. The position is sent when it has been improved. If it improves 
5 times in one seconds, it will be sent 5 times.

I would be very interested if anyone could provide an adb logcat output, 
because, again, I am unable to reproduce (and thus investigate) this bug.

Please only add comments if they add information. It is enough if one person 
files the bug.

Original comment by chm.duquesne on 7 Oct 2010 at 3:42

GoogleCodeExporter commented 9 years ago
I will look into this issue.
I already clone the repo and I have some mins now.

Original comment by maca...@gmail.com on 7 Oct 2010 at 3:48

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
Here's the log.
I will now look into the code.

Original comment by maca...@gmail.com on 7 Oct 2010 at 4:20

Attachments:

GoogleCodeExporter commented 9 years ago
Ok, the problem here is that the logic to stop the service depends on the 
onDestroy() method which might be not called.

http://code.google.com/p/android/issues/detail?id=7674
http://code.google.com/p/android/issues/detail?id=7033

I just fixed using an intent when starting the service.

       if ( intent.getAction().equals(STOP_SERVICE) ) {
           destroy();
           stopSelf();
           return;
       }

destroy() holds all the calls in the onDestroy() method.

I am a newbie to hg, I will google how to do the patch.

Original comment by maca...@gmail.com on 7 Oct 2010 at 4:58

GoogleCodeExporter commented 9 years ago
Here's the patch.

Original comment by maca...@gmail.com on 7 Oct 2010 at 5:08

Attachments: