agroal / pgagroal

High-performance connection pool for PostgreSQL
https://agroal.github.io/pgagroal/
BSD 3-Clause "New" or "Revised" License
667 stars 59 forks source link

Improve the `invalid master key file` error #424

Open fluca1978 opened 3 months ago

fluca1978 commented 3 months ago

In different points of main.c there are errors about the master key file, for example https://github.com/agroal/pgagroal/blob/master/src/main.c#L536. This can be confusing, since the user is not able to understand what is the problematic file: it could be a different file (e.g., pgagroal_users.conf that cannot be decrypted) or the master key file that does not exists. Moreover, all the errx calls exit with 1, while a more specific return code is probided into ret. More information should be reported both to systemd and to the user.

T1t4m1un commented 2 months ago

Could I take on this ticket?~ @fluca1978

jesperpedersen commented 2 months ago

@T1t4m1un Go for it

hariharan0905 commented 2 months ago

Is this issue got fixed!! or other wise can i go for it @jesperpedersen

jesperpedersen commented 2 months ago

@hariharan0905 @T1t4m1un is currently assigned to it...

@T1t4m1un Update ?

T1t4m1un commented 2 months ago

@hariharan0905 @T1t4m1un is currently assigned to it...

@T1t4m1un Update ?

Sorry I forget to update it!!! I'm not at the computer recently, I will update as soon as possible

fluca1978 commented 2 months ago

Il dom 5 mag 2024, 19:11 HARIHARAN KARTHICK @.***> ha scritto:

@fluca1978 https://github.com/fluca1978 Is this still this issue is assign to titanium

yes it is still assigned.

Reply to this email directly, view it on GitHub https://github.com/agroal/pgagroal/issues/424#issuecomment-2094881450, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGGUYEF3FO7U5GIHEYSFTLZAZR5HAVCNFSM6AAAAABFG72PX2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJUHA4DCNBVGA . You are receiving this because you were mentioned.Message ID: @.***>

jesperpedersen commented 2 months ago

@hariharan0905 Please, work on one issue at the time so we know what is being worked on

hariharan0905 commented 2 months ago

Ok sure!