agroal / pgagroal

High-performance connection pool for PostgreSQL
https://agroal.github.io/pgagroal/
BSD 3-Clause "New" or "Revised" License
684 stars 61 forks source link

Enable Vault Prometheus #454

Closed ashu3103 closed 4 months ago

ashu3103 commented 4 months ago

Enable Prometheus in vault

About this commit

Future work

@jesperpedersen @fluca1978 PTAL.

jesperpedersen commented 4 months ago

Remember the tutorial, man page and manual as well

ashu3103 commented 4 months ago

Remember the tutorial, man page and manual as well

Yeah working on it parallely

jesperpedersen commented 4 months ago

Maybe enable metrics by default in the pgagroal_vault.conf as well

jesperpedersen commented 4 months ago

I think that your "Future" section should be easy as well

jesperpedersen commented 4 months ago

prometheus should be initiated only when metric port is active --> Document it properly somewhere.

It is documented in the configuration files - users doesn't need to know about the internals

ashu3103 commented 4 months ago

prometheus should be initiated only when metric port is active --> Document it properly somewhere.

It is documented in the configuration files - users doesn't need to know about the internals

Yeah, but for new developers it might be required

jesperpedersen commented 4 months ago

You can put it in

ashu3103 commented 4 months ago

@jesperpedersen The suggested changes have been integrated PTAL.

jesperpedersen commented 4 months ago

I think it looks good but prometheus_common or prometheus_base is probably better as a name

jesperpedersen commented 4 months ago

Merged.

Thanks for your contribution !