agroimpacts / gediamazonia

Repo for SERVIR-related GEDI work over Peru
0 stars 1 forks source link

Pay attention to code syntax #1

Open ldemaz opened 4 years ago

ldemaz commented 4 years ago

Please mind code formatting conventions. e.g,

This

a <- 1:10

Rather than:

a<- 1:10
a<-1:10

And this:

gLevel2B<-gedifinder(product="GEDI02_B",ul_lat, ul_lon, lr_lat, lr_lon,version="001",daterange=daterange)

Should be:

gLevel2B <- gedifinder(product = "GEDI02_B", ul_lat, ul_lon, lr_lat, lr_lon, version = "001", daterange = daterange)

https://github.com/agroimpacts/gediamazonia/blob/71c6d3fda37a5e81b7abdad67c51be6494cd39ad/working/accessing_GEDI.Rmd#L25-L36

samwats254 commented 4 years ago

Sorry about that. Chunks of that code were copied from an online demo. I made the format changes.

Sam

From: Lyndon Estes notifications@github.com Sent: Monday, April 13, 2020 11:05 AM To: agroimpacts/gediamazonia gediamazonia@noreply.github.com Cc: Watson, Sam SWatson@clarku.edu; Assign assign@noreply.github.com Subject: [agroimpacts/gediamazonia] Pay attention to code syntax (#1)

Please mind code formatting conventions. e.g,

This

a <- 1:10

Rather than:

a<- 1:10

a<-1:10

And this:

gLevel2B<-gedifinder(product="GEDI02_B",ul_lat, ul_lon, lr_lat, lr_lon,version="001",daterange=daterange)

Should be:

gLevel2B <- gedifinder(product = "GEDI02_B", ul_lat, ul_lon, lr_lat, lr_lon, version = "001", daterange = daterange)

https://github.com/agroimpacts/gediamazonia/blob/71c6d3fda37a5e81b7abdad67c51be6494cd39ad/working/accessing_GEDI.Rmd#L25-L36https://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fagroimpacts%2Fgediamazonia%2Fblob%2F71c6d3fda37a5e81b7abdad67c51be6494cd39ad%2Fworking%2Faccessing_GEDI.Rmd%23L25-L36&data=02%7C01%7Cswatson%40clarku.edu%7C8b6cdf17ad52422658e808d7dfbc0cdd%7Cb5b2263d68aa453eb972aa1421410f80%7C1%7C0%7C637223871072983743&sdata=aXvT6HA0l%2FKpIP6WSsJxG%2Bl9WnMs6IQs34UrVONbt3A%3D&reserved=0

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHubhttps://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fagroimpacts%2Fgediamazonia%2Fissues%2F1&data=02%7C01%7Cswatson%40clarku.edu%7C8b6cdf17ad52422658e808d7dfbc0cdd%7Cb5b2263d68aa453eb972aa1421410f80%7C1%7C0%7C637223871072993736&sdata=g34szy8L6QuL1esKrGacIIpNVsq97IsOlFLrQ52omcU%3D&reserved=0, or unsubscribehttps://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FALTNNW7Y74LXLXMQXKYMY2DRMMS2DANCNFSM4MHAO3EA&data=02%7C01%7Cswatson%40clarku.edu%7C8b6cdf17ad52422658e808d7dfbc0cdd%7Cb5b2263d68aa453eb972aa1421410f80%7C1%7C0%7C637223871072993736&sdata=Q6kgWT7urdwDUTsAieyjHOjRZX0TjkL6EFTf%2FV80QKE%3D&reserved=0.

LLeiSong commented 4 years ago

Just one suggestion. There is a feature in Rstudio might be helpful: Rstudio menu -> Code -> Reformat code and Reindent Lines.