search

agronholm / apscheduler

Task scheduling library for Python
MIT License
5.98k stars 694 forks source link

tests: move to pytest-lazy-fixtures dep & mqtt update #865

Closed peterschutt closed 4 months ago

peterschutt commented 5 months ago

This PR addresses failing tests due to pytest-lazy-fixture incompatibility with pytest v8, and breaking changes in paho.mqtt v2.

Replaces pytest-lazy-fixture with pytest-lazy-fixtures, and adjusts use of mqtt client to conform to new api.

@agronholm now that https://github.com/dev-petrov/pytest-lazy-fixtures/issues/5 is closed and released I didn't know if you may want to jump over to that lib now to get things moving again. Either way, I can back that out and re-pin to pytest 7 and just address the mqtt stuff.

coveralls commented 5 months ago

Coverage Status

coverage: 92.468%. first build when pulling a8b488ea79e224bcd616dcb9832b7c0aa9e08787 on peterschutt:fix-tests into 8d26ee534218d3c7a29bb40523180e37e3db78a4 on agronholm:master.

agronholm commented 5 months ago

Not that it matters a lot, but why upgrade the pytest dependency?

peterschutt commented 5 months ago

Not that it matters a lot, but why upgrade the pytest dependency?

Changed to >=7.4.

agronholm commented 4 months ago

Thanks!