search

agronholm / apscheduler

Task scheduling library for Python
MIT License
6.18k stars 704 forks source link

Makes `__{a}exit__` method args nullable. #875

Closed peterschutt closed 7 months ago

peterschutt commented 7 months ago

This makes the methods compatible with typeshed's ABCs: https://github.com/python/typeshed/blob/5e9589dd75f8a5f39a38a2ed45f098ff62babc7f/stdlib/contextlib.pyi#L40-L54

Closes #874

coveralls commented 7 months ago

Coverage Status

coverage: 92.468%. first build when pulling 8f1b6c562e8f867ca4543ab80033d26673650372 on peterschutt:cm-exit-method-typing into 5fac5ba511e09b6e86e06b1b46f18e654ba59e35 on agronholm:master.

agronholm commented 7 months ago

Thanks, this is a mistake I make from time to time. I know this is how they should look like though!