Wakeup worker when there are resources freed up

agronholm / apscheduler

Task scheduling library for Python

MIT License

5.94k stars 690 forks source link

Wakeup worker when there are resources freed up #882

Closed mavahedinia closed 2 months ago

mavahedinia commented 3 months ago

Related to the bug reported on Issue#881.

mavahedinia commented 3 months ago

I would appreciate if you can help me understand why some tests are failing. @agronholm

agronholm commented 3 months ago

Would it be possible for you to add a regression test for this? As for the other tests failing, I can probably take a look later.

agronholm commented 3 months ago

Oh, and also add a changelog entry (credit yourself too).

mavahedinia commented 3 months ago

I will look into writing tests over the weekend. Thanks for your fast response!

agronholm commented 2 months ago

Any progress on those tests?

mavahedinia commented 2 months ago

Sorry man, I am so busy with moving that haven't had any chance to look at it.

agronholm commented 2 months ago

One issue I have with this PR is that it needlessly wakes up the job processor whenever a job is released, not just when the processor was previously at capacity. Could you fix that?

agronholm commented 2 months ago

But if you're still busy with IRL stuff, let me know and I'll look into fixing it and writing tests.

coveralls commented 2 months ago

coverage: 92.614%. first build when pulling ce74e1e5d06c3ff22fcb0091a2f63df96a9ce4e2 on mavahedinia:fix-worker-deadlock into fad16ec0866c4eea9d44c17071e1ae81e782d0ca on agronholm:master.

agronholm commented 2 months ago

I've added the test and changelog entry on your behalf. Thank you for the contribution!