SQLAlchemy store should remove finished schedules on cleanup

agronholm / apscheduler

Task scheduling library for Python

MIT License

5.93k stars 690 forks source link

SQLAlchemy store should remove finished schedules on cleanup #889

Closed Reskov closed 2 months ago

Reskov commented 3 months ago

It looks like a typo error because a similar code in the mongodb/memory module deletes finished schedules.

I have modified a test case for two reasons: 1) it was not executed on all data stores 2) the anyio.Event() is not serializable across different datastores, resulting in an error before execution.

coveralls commented 3 months ago

coverage: 92.596% (+0.04%) from 92.561% when pulling c9417122aab34b69aea75a34b40ee1c6ce748cef on Reskov:asyncpg-cleanup-fix into 65b7606dd94996e2fa46526b0e6ceb90fff0f9b5 on agronholm:master.

agronholm commented 2 months ago

Looks good at a glance. I'll give it a proper review within a couple days.

agronholm commented 2 months ago

Thank you!