fix RedisJobStore .add_job() .update_job() param error

agronholm / apscheduler

Task scheduling library for Python

MIT License

5.94k stars 690 forks source link

fix RedisJobStore .add_job() .update_job() param error #905

Closed tomnkey closed 2 months ago

tomnkey commented 2 months ago

redis zadd function score pairs should be specified in two ways:

As *args, in the form of: name1, score1, name2, score2, ...
or as **kwargs, in the form of: name1=score1, name2=score2, ...

agronholm commented 2 months ago

Where did you get this idea?

agronholm commented 2 months ago

As you can see in the documentation, the second argument should be a mapping of keys to values, which is what APScheduler is passing it. As further proof, see the failing tests here.

What prompted this PR in the first place?