agronholm / cbor2

Python CBOR (de)serializer with extensive tag support
MIT License
228 stars 59 forks source link

Complex number support #249

Open chillenb opened 1 week ago

chillenb commented 1 week ago

Changes

Fixes #248

Adds support for complex numbers under tag 43000.

Checklist

If this is a user-facing code change, like a bugfix or a new feature, please ensure that you've fulfilled the following conditions (where applicable):

If this is a trivial change, like a typo fix or a code reformatting, then you can ignore these instructions.

Updating the changelog

If there are no entries after the last release, use **UNRELEASED** as the version. If, say, your patch fixes issue #999, the entry should look like this:

- Fixed big bad boo-boo in the encoder (#999 <https://github.com/agronholm/cbor2/issues/999>_; PR by @yourgithubaccount)

If there's no issue linked, just link to your pull request instead by updating the changelog after you've created the PR.

coveralls commented 1 week ago

Coverage Status

coverage: 93.248% (-0.3%) from 93.542% when pulling 1c4da623aeecf235d96f4387176a1a89442cd84b on chillenb:complex into d9cee77308056776859d40c81a82fac5f414d4db on agronholm:master.

chillenb commented 1 week ago

Not sure what's happening with the fuzzer. It doesn't look like it ran properly?

agronholm commented 1 week ago

Not sure what's happening with the fuzzer. It doesn't look like it ran properly?

Don't worry about that. It never worked right, and I haven't been able to reach the person who added it. I haven't decided what to do about it yet.