agronholm / exceptiongroup

Backport of PEP 654 (exception groups)
Other
42 stars 20 forks source link

BaseExceptionGroup.derive should not copy __notes__ #112

Closed cfbolz closed 8 months ago

cfbolz commented 8 months ago

this makes the behaviour follow that of CPython more closely. Instead, copy notes (if present) in the callers of derive. The (modified) test passes now, and it passes on py3.11. It fails before the changes. #111

coveralls commented 8 months ago

Pull Request Test Coverage Report for Build 8155139303

Details


Totals Coverage Status
Change from base Build 7973406898: 0.02%
Covered Lines: 552
Relevant Lines: 561

💛 - Coveralls
agronholm commented 8 months ago

Does anything here actually test that derive() doesn't copy __notes__?

cfbolz commented 8 months ago

Does anything here actually test that derive() doesn't copy __notes__?

The test changes that I did tests it, but very indirectly. So I've now added an explicit test.

agronholm commented 8 months ago

Thanks!