agronholm / exceptiongroup

Backport of PEP 654 (exception groups)
Other
42 stars 20 forks source link

Work around CPython bug in `HTTPError` #58

Closed Zac-HD closed 1 year ago

Zac-HD commented 1 year ago

Workaround for https://github.com/python/cpython/issues/98778 (aka https://github.com/python/cpython/issues/90113), in order to fix https://github.com/pytest-dev/pytest/issues/10797.

This is a little ugly but I thought we'd prefer to keep it tightly scoped rather than suppressing anything raised by getattr().

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 4399424903


Files with Coverage Reduction New Missed Lines %
/opt/hostedtoolcache/PyPy/3.8.16/x64/lib/pypy3.8/site-packages/exceptiongroup/_exceptions.py 1 89.86%
/opt/hostedtoolcache/Python/3.7.15/x64/lib/python3.7/site-packages/exceptiongroup/_formatting.py 45 69.68%
/opt/hostedtoolcache/Python/3.8.16/x64/lib/python3.8/site-packages/exceptiongroup/_formatting.py 45 69.87%
/opt/hostedtoolcache/Python/3.9.16/x64/lib/python3.9/site-packages/exceptiongroup/_formatting.py 46 69.87%
/opt/hostedtoolcache/PyPy/3.8.16/x64/lib/pypy3.8/site-packages/exceptiongroup/_formatting.py 99 16.99%
<!-- Total: 236 -->
Totals Coverage Status
Change from base Build 4115259050: -0.3%
Covered Lines: 2065
Relevant Lines: 3166

💛 - Coveralls
agronholm commented 1 year ago

I'm a bit confused. There was only a new test added?

Zac-HD commented 1 year ago

I wanted to see CI fail on old versions before pushing the fix, and... it's not failing yet 😅

Zac-HD commented 1 year ago

@agronholm done, albeit with two more commits than I'd planned.

agronholm commented 1 year ago

Thanks!

agronholm commented 1 year ago

I almost missed the wrong hyperlink format in the changelog. Fixing.

agronholm commented 1 year ago

Released v1.1.1.