search

agronholm / pythonfutures

Backport of the concurrent.futures package to Python 2.6 and 2.7
Other
232 stars 51 forks source link

Add thread initializer (from Python 3.7) #93

Closed fahhem closed 5 years ago

fahhem commented 5 years ago

Hmm, the tests are significantly different from upstream (upstream seems to have improved them significantly).

Should I just re-backport the latest from 3.7 or just pull in thread initializers?

agronholm commented 5 years ago

Hmm, the tests are significantly different from upstream (upstream seems to have improved them significantly).

Should I just re-backport the latest from 3.7 or just pull in thread initializers?

I'm not sure that the tests are fully applicable to the backport (as the upstream code is not). The initializer related test should be sufficient (as it seems you've already done).

agronholm commented 5 years ago

I'm going to have to fix the test run for py2.6 and make sure it passes before merging this.

agronholm commented 5 years ago

Thanks!

agronholm commented 5 years ago

Hm, now we have a partial implementation of bpo-21423. I don't suppose I could ask you to make a PR covering process pools too? I'm not comfortable making a release with a halfway implemented feature.

fahhem commented 4 years ago

Here's the PR: https://github.com/agronholm/pythonfutures/pull/94