search

agronholm / sqlacodegen

Automatic model code generator for SQLAlchemy
Other
1.87k stars 243 forks source link

--generator sqlmodels unavailable #219

Closed gitkeerthi closed 2 years ago

gitkeerthi commented 2 years ago 
$ sqlacodegen --version                                             
3.0.0rc1
$ sqlacodegen --generator sqlmodels postgresql+psycopg2://*********@localhost/*****
usage: sqlacodegen [-h] [--option [OPTION ...]] [--version] [--schemas SCHEMAS] [--generator {dataclasses,declarative,tables}]
                   [--tables TABLES] [--noviews] [--outfile OUTFILE]
                   [url]
sqlacodegen: error: argument --generator: invalid choice: 'sqlmodels' (choose from 'dataclasses', 'declarative', 'tables')

But your README says otherwise.

agronholm commented 2 years ago

If you took the time to read the changelog, you would notice that the feature has not yet been released.

gitkeerthi commented 2 years ago

Rather you should have taken time and not publish a README with something that was not released lmao

agronholm commented 2 years ago

I didn't publish it in a release, did I? Do you have any clue about how open source development works?

marc-odp commented 1 year ago

Not well obviously.

marc-odp commented 1 year ago

I mean... Having the readme mentioning a feature that was not released doesn't make any sense and you should probably edit the readme asap.

agronholm commented 1 year ago

The README on PyPI does not mention SQLModel support. If you're reading the README on GitHub where the latest code lives, then feel free to install that code straight from VCS and use that feature. But it's unreasonable to expect README (and changelog, I assume) changes to be deferred in VCS too until a release happens instead of happening directly in the pull requests.