Support Python 3.13 - Githubissues

agronholm / typeguard

Run-time type checker for Python

Other

1.5k stars 112 forks source link

Support Python 3.13 #460

Closed JelleZijlstra closed 3 months ago

JelleZijlstra commented 3 months ago

typing.is_typeddict() does not recognize typing_extensions.TypedDict
ForwardRef._evaluate gained another parameter

JelleZijlstra commented 3 months ago

The test failures are due to some pytest deprecation; it's not immediately obvious where the problem is.

JelleZijlstra commented 3 months ago

The good news is that my draft PEP 649 implementation (https://github.com/python/cpython/pull/119361) passes the entire test suite, once this change is implied and I ignore the pytest deprecation.

agronholm commented 3 months ago

This needs additional tests. If typing_extensions is to be imported unconditionally, then the conditional dependency on it in pyproject.toml must be made unconditional.

EDIT: The test that would be needed is a test for recognizing typing_extensions.TypedDict.

JelleZijlstra commented 3 months ago

The test suite already tests for both typing.TypedDict and typing_extensions.TypedDict; it uses the typing_provider fixture to use both. However, I'll add a direct test for is_typeddict.

coveralls commented 3 months ago

coverage: 93.988%. first build when pulling 82f38720176e63b7891a517a4d2e52581271bf55 on JelleZijlstra:py313 into dd3fc1ecda7a61d7d651f9a1cc617c89628829dc on agronholm:master.

agronholm commented 3 months ago

Thanks!!