search

agronick / Relay

An IRC client designed for elementary OS
https://poisonpacket.wordpress.com/relay/
GNU General Public License v2.0
88 stars 15 forks source link

Use HeaderBar.subtitle() for server name #12

Closed quassy closed 9 years ago

quassy commented 9 years ago

Instead of putting the room and server name onto one line this commit puts the server name in the headerbar subtitle. Only problem right now is that in the server window the server name is displayed twice.

Some lines have been changed by Scratch which likes to remove trailing whitespace. Only the additions of various toolbar.set_subtilte(...) are actually significant changes.

agronick commented 9 years ago

Can you fix it to remove the channel from the main title, then do a find for set_title and put toolbar.set_subtilte("") wherever else it sets the title and I'll be able to merge it.

agronick commented 9 years ago

It only sets the title in main_window.vala

agronick commented 9 years ago

Actually I can do it if you want

quassy commented 9 years ago

Can you fix it to remove the channel from the main title, then do a find for set_title and put toolbar.set_subtilte("") wherever else it sets the title and I'll be able to merge it.

I'm not sure I get what you mean. I have tried to set / unset the subtitle every time the title is set so the subtitle gets removed when you return to the Welcome tab for example. Also to unset the title I think it's better to use set_subtitle(null).

agronick commented 9 years ago

I just committed a fix

quassy commented 9 years ago

Your commit seems to do something completely different :D

quassy commented 9 years ago

Here is what my changes were doing: relay use subtitle

agronick commented 9 years ago

Thats what it should be doing screenshot from 2015-07-06 02 18 17

quassy commented 9 years ago

Sorry, just checked out yours from git and it works as expected. A screenshot as proof (also to show that Relay works under Solus too) relay

agronick commented 9 years ago

Check it out now. Theres a ton of new updates. I added a bunch of settings too.

On Fri, Jul 10, 2015 at 7:58 PM, quassy notifications@github.com wrote:

Sorry, just checked out yours from git and it works as expected. A screenshot as proof (also to show that Relay works under Solus too)

— Reply to this email directly or view it on GitHub.