agroportal / project-management

Repository used to consolidate documentation about the AgroPortal project and track content related issues.
http://agroportal.lirmm.fr
7 stars 0 forks source link

Expected behaviour with multiple mapped properties with different types #425

Closed jonquet closed 1 year ago

jonquet commented 1 year ago

We have an example of a SKOS resource in AgroPortal, which provides 2 definitons: https://agroportal.lirmm.fr/ontologies/ANAEETHES/?p=classes

Capture d’écran 2023-06-08 à 05 16 17

Which ends up in the API as

Capture d’écran 2023-06-08 à 05 22 54

(the difference of types creates a non regular JSON structure)

Which ends up in the UI as

Capture d’écran 2023-06-08 à 05 22 11

(Similar situation could happen with synonyms which are also mapped to a unique "synonym" property).

What is the expected behaviour when this situation occurs? We can expect the display and the JSON being well structured.

syphax-bouazzouni commented 1 year ago

We can expect the display and the JSON being well structured.

So it's more of a UI bug.

When it's an object it needs to be shown as a link (for now, in the future we will fetch more data about it )

I assign @SirineMhedhbi to fix this.

syphax-bouazzouni commented 1 year ago

Fixed with https://github.com/ontoportal-lirmm/bioportal_web_ui/pull/273

jonquet commented 1 year ago

Penser a gèrer le cas ou les valeurs sont des objects (URI) pour les afficher comme des "boutons"

SirineMhedhbi commented 1 year ago

@jonquet Done

syphax-bouazzouni commented 1 year ago

@jonquet Done

@SirineMhedhbi done where? you need to give a link to your commit fix or new PR and a screenshot so that we can see it.

In this case, the commit is https://github.com/ontoportal-lirmm/bioportal_web_ui/commit/67ff34cceacb7149f5d73a075a5fa63e565e3be5

But for the PR, you will need to open a new one as a follow-up of this https://github.com/ontoportal-lirmm/bioportal_web_ui/pull/273 (because already closed)

Thanks;

SirineMhedhbi commented 1 year ago

@syphax-bouazzouni

okay thanks

image

SirineMhedhbi commented 1 year ago

@syphax-bouazzouni this is the new PR : https://github.com/ontoportal-lirmm/bioportal_web_ui/pull/280