search

agross / immich-duplicates

Find image and video duplicates in Immich.
136 stars 5 forks source link

Can't mark photos to keep #10

Closed ioslife closed 1 year ago

ioslife commented 1 year ago

Hi there,

Getting the below error when clicking the keep button or pressing K:

TypeError: (await O.deleteAsset({ids:G})).data.filter is not a function. (In '(await O.deleteAsset({ids:G})).data.filter(le=>le.status!=="SUCCESS")', '(await O.deleteAsset({ids:G})).data.filter' is undefined)

Any ideas?

agross commented 1 year ago

I confirmed that the error occurred for me as well. Researching now.

agross commented 1 year ago

This bug is likely caused because https://github.com/immich-app/immich/pull/4015 changed the response of the DELETE /asset endpoint to no longer return content.

agross commented 1 year ago

Please test the new commit (an updated docker image is being built right now) and let me know if the issue is fixed for you.

ioslife commented 1 year ago

Working now. Thanks!

ioslife commented 1 year ago

@agross, Delete All is giving a similar error.

TypeError: (await O.deleteAsset({ids:[...s.value.keys()]})).data.filter is not a function. (In '(await O.deleteAsset({ids:[...s.value.keys()]})).data.filter(G=>G.status!=="SUCCESS")', '(await O.deleteAsset({ids:[...s.value.keys()]})).data.filter' is undefined)

agross commented 1 year ago

Thank makes sense since it uses the same endpoint, but I did not change the code that invokes it. An updated image is underway.