search

agross / immich-duplicates

Find image and video duplicates in Immich.
136 stars 5 forks source link

Feature request: Quick overview of all changes > Accept All #7

Open Drudoo opened 1 year ago

Drudoo commented 1 year ago

Amazing app. Just used it on my immich setup and it worked wonders. Had a bunch of jpg + heic photos to de-duplicate.

Would it be possible to get an overview of all the changes and then a way to accept all (keep best)? Going through hundreds or thousands of duplicates one at a time can be very time consuming compared to having a quick overview.

agross commented 1 year ago

I indeed second your idea to get an overview. I had about 1,2k duplicate groups after my data import. A website displaying 1200 groups with >= 2 assets per group will unlikely be performant. And for my assets, there were several cases where the decision of which asset to keep was more involved than clicking the "Keep best asset" button. I don't know if such a "Just do it" button would be viable. I suggest we collect more feedback before I go about implementing this.

Cantello commented 1 year ago

Would be very much in favour of this. Implement the same basic rules as before ('keep best photo' & 'move photos to album of best photo'). Additionally, please have assets with different type marked as a separate group, as these are often only the video's thumbnail (at least on iOS). Have 1349 duplicate groups now and am not looking forward to deleting every single one of these... (however, very grateful to you for allowing me to choose these duplicate photos!).

gismo2004 commented 1 year ago

This is most likely now a dumb question, but why do you build an external tool for something that could be contributed to immich directly? I am using immich on a k8s server with PVC data storage for thumbnails, thus it's quite hard do read thumbs from there while the app is up and running.

I think your approach detecting duplicates is awsome, but it would be much more helpful if it is somewhat integrated and it would be a big improvement for immich!

Edit: do you know VisiPics? It is my favorite de-duplication tool as it provides a very neat auto select mechanism. Do you know about it?

agross commented 1 year ago

This is most likely now a dumb question

There are no dumb questions, only dumb answers ;-)

Some reasons:

  1. I have another PR with Immich regarding an unrelated feature for the mobile app that remains open for weeks and does not appear to be considered by the dev team.
  2. The frontend libraries used here (Vue) differ from what Immich uses (Svelte).
  3. I am not a frontend developer. I needed a solution for my duplicates and Vue is something I somewhat know (no experience with Svelte). I've published the project here because there were other people with the same use-case (see GH discussions on Immich), but I didn't strive for perfection or integrateability since deduping is mostly a one-time activity.
  4. Since the approach of finding dupes is quite involved (running against your /thumbs on your server) I am not sure if the Immich team would accept the solution presented here.

Regarding your k8s PVC, if you are able to gain access to the physical volume/files outside of k8s I think it's quite easy to run findimagedupes against it. Or you could mount the same PVC in a separate pod?

Regarding VisiPics, this is the first time I learn about this.

gismo2004 commented 1 year ago

Thank you for the answer! That is very understandable now.

About the PVC thingy: It's not impossible to mount it, and ofc it's possible to use it with your tool... I just mentioned it because I thought it would be wayyy more handy if your "tool" would me integrated in immich directly. Now that I/we know some more details it's understandable why this might never happen 😔

VisiPics is very old and unfortunately not maintained anymore, but up to now I haven't found anything that works that simple and reliable... So maybe it's kind of rolemodel for further work on your tool 🤓

Cantello commented 1 year ago

If I were to use an external tool like, say Visipcs, is there any way to have Immich check, which assets are available and which ones have been deleted?

So far I have been very happy with Immich-duplicates as it really is a one-time thing to do - that way the simpler front-end does not bother too much.

jrasm91 commented 1 year ago

This is pretty cool. I'm sure we could look at integrating it into immich in the future.