agroszer / komodo-python3-dbgp

Other
3 stars 3 forks source link

Issues with Mac OS and usage with vim #1

Open treycucco opened 5 years ago

treycucco commented 5 years ago

Hi there,

I use a vim plugin called vdebug (https://github.com/vim-vdebug/vdebug) which recommends using ActiveState's pydbgp tool. I tried it out and ran into a few issues on Mac OS:

1) When pip installing komodo-python3-dbgp I get a setup error that plat is references before assignment. This is because the platform check in setup.py is checking for windows and linux but misses mac os.

2) When a python script finishes running the debugger does not detach and I have to use ctrl-z to end it

I have forked this repo and fixed both of those issues, but I wanted to check to see if you're open to pull requests on this, or if this is just a copy of something internal to ActiveState.

Also, I'm not 100% sure that my solution to #2 is the most correct solution, or that I'm not missing something in how it is intended to work.

agroszer commented 5 years ago

Hi,

Good news and bad news...

Good news is if you got setup on a mac right, I'm happy to accept it. Bad news is that is a small wrapper around the Activestate pydbgp module which can be downloaded from http://downloads.activestate.com/Komodo/releases/11.1.1/remotedebugging/ . So I rather don't fuzz with it's internals. On a release I basically download the files from activestate and just replace here in the repo. If you have fixes for pydbgp, try to nudge the activestate guys to merge it.

cipriantarta commented 4 years ago

They also have a macos version in the download page. Would that not help?

agroszer commented 4 years ago

Hi,

The problem is I do not own a mac, neither have access to one. If you can provide a PR that does the job, I'm happy to accept it.