Closed agrueneberg closed 10 years ago
Hi Douglas! The reason why I didn't merge this one yet is because I'd have to change the API and I wanted to collect more potentially API changing issues before releasing 2.0. I just realized it's been more than a year now, so I guess I waited long enough :smile: The issues for 2.0 are tracked here: https://github.com/agrueneberg/Corser/issues?milestone=1 If you can think of other cool features, feel free to add issues or open pull requests! Thanks!
I'll set up a dev branch and merge this issue with it.
Thanks! I figured as much, but wasn't sure since a lot of time had passed :)
The main features I was looking for was #11 and #12 (but 12 can be worked-around, 11 can only be worked around with... domains).
Also many thanks for writing up this library that actually follows the CORS spec!
Doug, both issues are fixed in the dev branch. Preflights are now closed by default (see #12). I added an options called endPreflightRequests
that users can set to false
if they want to keep the old behavior. Any feedback?
Awesome! Thank you soo much. I'll pull down these changes and go about using them in an app I have to provide some hands-on feedback later today :)
Great, thank you :+1:
OK, I have just implemented against both features that they work well for me :+1:
Thanks for testing, Doug. I released version 2.0.0.
Yes, thank you so much! I saw that before I sent the code to production, so it is officially using 2.0.0 on my end. :palm_tree:
Hi @agrueneberg ! I have a lot of interest in this module recently and saw this PR which is functionality that I am looking for in this module. I am wondering if I could offer to help in any way towards the 2.0 release.