search

agsh / onvif

ONVIF node.js implementation
http://agsh.github.io/onvif/
MIT License
693 stars 236 forks source link

Add setSystemFactoryDefault request #138

Closed bl0ggy closed 4 years ago

bl0ggy commented 4 years ago

Nothing to say about this. Just add a new ONVIF request.

coveralls commented 4 years ago

Coverage Status

Coverage decreased (-4.9%) to 82.395% when pulling bb7353874e23412789b76848b1397a68a49eb4c3 on bl0ggy:add_setSystemFactoryDefault into 2a7f9fe267058e8d069253f7d1189e5744b09470 on agsh:master.

bl0ggy commented 4 years ago

I added a test, but it covers less than before ? I think coveralls has a bug haha, probably because I made multiple PRs.

RogerHardiman commented 4 years ago

Hi Thanks for the tests.

There used to be a way to make the tests run against a real camera by setting HOSTNAME, PORT, USERNAME and PASSWORD as environment variables. However I think it is broken at the moment.

But assuming it gets fixed, we would want to block the Reset (and also the Reboot commands) or our tests against a real camera would make the camera reboot and other tests would time out.

Anyway this is fine for the Mock server.