Add User related requests

agsh / onvif

ONVIF node.js implementation

http://agsh.github.io/onvif/

MIT License

693 stars 236 forks source link

Add User related requests #140

Closed bl0ggy closed 3 years ago

bl0ggy commented 4 years ago

Add ONVIF requests for User management. I didn't know if I had to create a new .js file or not.

I have not made any test, I don't know how to configure responses in the serverMockup.

coveralls commented 4 years ago

Coverage decreased (-0.6%) to 87.293% when pulling 4b80ffcf38be5ff53003b24b191828614a32570b on bl0ggy:add_user_requests into f8ee914a9f5a8cab0acdb70f4efb0e4d0f56836f on agsh:master.

RogerHardiman commented 4 years ago

https://www.onvif.org/ver10/device/wsdl/devicemgmt.wsdl

These are in the 'device.wsdl' part of the ONVIF spec so they should go in device.js

There are lots of bits of cam.js that should be in device.js too, but that is just historical.

If you could move them into device.js that would be great.

sjkummer commented 4 years ago

Would be great to have this merged. Is moving the functions from cam.js to device.js the only thing which is blocking the merge, or is there something else too?

RogerHardiman commented 4 years ago

The biggest blocker is lack of time. We all work on this library in our spare time and I've no spare time at the moment and as I type this I've got to prep for a conference call in 35 mins for my job.

sjkummer commented 4 years ago

Ok, I understand. If there is something that should be changed in this PR, I am willing to do it.

RogerHardiman commented 3 years ago

I am slowly catching up on Pull Requests. This is now in master