search

agsh / onvif

ONVIF node.js implementation
http://agsh.github.io/onvif/
MIT License
693 stars 236 forks source link

Added network related requests #143

Closed bl0ggy closed 4 years ago

bl0ggy commented 4 years ago

Added some network related ONVIF requests. Fixed JSDoc.

coveralls commented 4 years ago

Coverage Status

Coverage decreased (-4.7%) to 82.603% when pulling f8967e133af05efb6bb538a402cea2d83b58a00b on bl0ggy:add_network_related_requests into 2a7f9fe267058e8d069253f7d1189e5744b09470 on agsh:master.

RogerHardiman commented 4 years ago

Hi. Would be good if you could add a test to the Mock Server. You may not have looked at it before but in the /test folder is a mini fake ONVIF Server. The XML it returns is mostly hard coded and there are lots of files containing the XML that has been copied from other ONVIF cameras (often with a wireshark grab) So you may need to grab some results from one of your cameras and then add them to the Mock Server and add some test programs. That will get the Percentage Coverage back up.