search

agsh / onvif

ONVIF node.js implementation
http://agsh.github.io/onvif/
MIT License
693 stars 236 forks source link

Fix getNetworkInterfaces response returning a non-array #147

Closed bl0ggy closed 3 years ago

bl0ggy commented 4 years ago

when only one network inteface is returned. The returned object is now the Array of network interfaces (as declared in the JSDoc) instead of an object containing the array. This breaks backward compatibility! Also breaks the test I added in the PR #144, depending on which PR is accepted first, I will add commit on this PR or the other.

coveralls commented 4 years ago

Coverage Status

Coverage decreased (-0.1%) to 82.126% when pulling 45e6db996a341b18be204e2eebb271fa45332051 on bl0ggy:fix_getNetworkInterfaces_response into 1a995579d7917ddd555304804eeb94af38408fc9 on agsh:master.