search

agsh / onvif

ONVIF node.js implementation
http://agsh.github.io/onvif/
MIT License
693 stars 236 forks source link

Improve `setVideoEncoderConfiguration`. #148

Open bl0ggy opened 4 years ago

bl0ggy commented 4 years ago

Fix names in setVideoEncoderConfiguration. Update JSDoc.

Rename following the ONVIF specs. This also permit to getVideoEncoderConfiguration, modify the object returned then use it to setVideoEncoderConfiguration. Before that we had to convert mpeg4Profile and H264Profile keys to profile.

EDIT: this breaks backward compatibility, we may change this to try both mpeg4Profile and profile then both H264Profile and profile

coveralls commented 4 years ago

Coverage Status

Coverage remained the same at 87.904% when pulling 5e692dd4eca18766edbaa8d6d0bbbd88f5d541ac on bl0ggy:improve_setVideoEncoderConfiguration into f8ee914a9f5a8cab0acdb70f4efb0e4d0f56836f on agsh:master.