search

agsh / onvif

ONVIF node.js implementation
http://agsh.github.io/onvif/
MIT License
692 stars 234 forks source link

Make Cam works properly like EventEmitter inheritor #181

Closed agsh closed 3 years ago

agsh commented 3 years ago

Hi! I remembered a conversation that was in May ( sometimes I do it ;) ): https://github.com/agsh/onvif/pull/137 https://github.com/agsh/onvif/pull/161

And finally remove eventEmitter property and made right inheritance from EventEmitter

Since I have not had a camera for testing for two years, please check the code and maybe test it on the device.

coveralls commented 3 years ago

Coverage Status

Coverage increased (+0.4%) to 88.401% when pulling 0904014a7681cd0525d85c3f3ef426075d1095ee on revert-event-emitter into fe5d7f39dba57729ccfe5380198eaca2adb236cd on master.