search

agsh / onvif

ONVIF node.js implementation
http://agsh.github.io/onvif/
MIT License
692 stars 234 forks source link

Merge getSystemDateAndTime and 'timeShift' fixes to master #186

Closed RogerHardiman closed 3 years ago

RogerHardiman commented 3 years ago

I'll be using these fixes on a live project but wanted @agsh and maybe @chriswiggins to take a look first.

RogerHardiman commented 3 years ago

Hi Andrew. I had not thought about 'let' and old NodeJS versions. All my projects use Node v8 or above now and there are other places in the library that use 'let'. Increasing the minimum version of Node seems to be a good idea

chriswiggins commented 3 years ago

This seems to be a good change to me - I don't have anything to test it on currently but LGTM!

RogerHardiman commented 3 years ago

@chriswiggins - Many thanks for the quick review.