agsh / onvif

ONVIF node.js implementation
http://agsh.github.io/onvif/
MIT License
692 stars 234 forks source link

Discovery Node Issue #205

Closed Eman457 closed 2 years ago

Eman457 commented 2 years ago

Hi, I updated to the latest version and this broke down everything! The Discovery Node doesn't find cameras any more

bartbutenaers commented 2 years ago

Dear @Eman457,,

A few days ago I had a quick look at the discovery code, and it seemed to me that e.g. a NAS (see full description here) could perhaps cause the discovery to fail. But not really sure at the moment to be honest...

However today I have installed the latest version of this library, and I also don't get any devices anymore via discovery. So I have used the new error event handler (as described on the readme page), to see what is going wrong. And then I see this error: Discovery error Wrong SOAP message from xxxxxx. The xxxxx is the IP address from my Onvif camera that was discovered without problems previously. So this is not the same problem as I had reported in my other issue...

Bart

bartbutenaers commented 2 years ago

I wanted to debug what was going wrong. So I have repeated the discovery process now a series of times again, and now it works fine every time. Not sure what went wrong in the beginning...

agsh commented 2 years ago

@Eman457 @bartbutenaers Wow, guys, I've looked at discovery module, but didn't see any changes. Maybe @RogerHardiman can help us?

Eman457 commented 2 years ago

Hello @bartbutenaers , I updated again to a version showing 13hrs at the time I type this and the Discovery Node woke up and shows connected but lost features which were all working before the git version. Is there any chance we can go back to the beta before the git version?... This one errors with "The device has no support for a ptz service" All was working fine until now...

bartbutenaers commented 2 years ago

@Eman457,

the Discovery Node woke up and shows connected but lost features which were all working before the git version

Ah ok you are using my node-red-contrib-onvif-nodes. Perhaps it is better if you create a new issue in my repository, because this might be very confusing for Andrew and Roger. I first need to know if there is an issue with my own code or not...

We will discuss there further ...

his one errors with "The device has no support for a ptz service"

I assume you are not talking now about Discovery but about PTZ? If so: yes I updated my git repository to use the latest (0.6.5) version of the agsh/onvif library. But somebody reported me issues, which were caused by a breaking change (via this pull request): for my old panasonic camera's capabilities where returned, while REolink camera's now have `undefined capabilities. That is hopefully all solved in my Github version. But the same guy reported that his Discovery doesn't work anymore. So we need to start searching

@agsh or @RogerHardiman : do you know any way how to troubleshoot discovery issues for other remote users? Via port forwarding I can connect to remote cams and debug the code without problems. But I cannot start a discovery from my computer on someone else his LAN? If you know any tricks, please share those!

Eman457 commented 2 years ago

Hi @bartbutenaers , I have update to yesterday's updated version and can confirm that the features are back! The PTZ nodes are showing green

bartbutenaers commented 2 years ago

@Eman457, Nice to hear that my fix solved it. Thanks for letting me know!

My last version on Github takes into accounts that - due to the pull request I mentioned above - I need to check the capabilities in multiple ways (as you can see here). All people that had troubles with their cameras have already reported that things are solved now. So can you please close this issue? If you would run into other problems in the future, then please raise an issue on my own Github repository.

Bart

Eman457 commented 2 years ago

@bartbutenaers , Sorry for not closing the issue when I had to but looks good so far.

And thank you.