search

agsh / onvif

ONVIF node.js implementation
http://agsh.github.io/onvif/
MIT License
692 stars 234 forks source link

#214 tests in js #215

Closed agsh closed 2 years ago

agsh commented 2 years ago

Just in progress yet. To rewrite tests to refuse coffescript

agsh commented 2 years ago

BTW, I need to think how to apply TravisCI or smth else to test PRs..

RogerHardiman commented 2 years ago

Removing coffee script is good. When I've added tests in the past, it was one more thing to learn, so this makes things easier.

Upgrading the dependencies is a good idea.

Roger

RogerHardiman commented 2 years ago

I've had a look through the current changes. They all look fine. Looks like 5 more .coffee files to convert. (or check in the .js transpiled versions)

agsh commented 2 years ago

Thanks! I am still working :smile: