search

agsh / onvif

ONVIF node.js implementation
http://agsh.github.io/onvif/
MIT License
681 stars 231 forks source link

Do not pull events if creating the pull-point subscribtion failed. #230

Closed sjkummer closed 2 years ago

sjkummer commented 2 years ago

Do not pull events if creating the pull-point subscribtion failed.

agsh commented 2 years ago

@sjkummer Hello! Thanks for the PR! It seems that your branch is a little bit older than the origin/master: This branch is 1 commit ahead, 129 commits behind agsh/onvif:master. :smile: Maybe this bug is already fixed in the current version. Can you check?

sjkummer commented 2 years ago

@agsh Yes, forgot to create a PR back then 😅 will run a test with the newest version

sjkummer commented 2 years ago

I synced with master. From what I see, this exception can still occur.

Since this uncatched exception takes place within the library, an application that uses this library does not have a clean way to catch it and wll crash unless it overrides the general uncaughtException handler of the process which is not recommended.

agsh commented 2 years ago

@sjkummer Sorry for the late response. Thanks a lot for the PR! Should I bump the version in the npm?