search

agsh / onvif

ONVIF node.js implementation
http://agsh.github.io/onvif/
MIT License
681 stars 231 forks source link

[feat] implemented custom OSD position #270

Closed yuxiaolejs closed 1 year ago

yuxiaolejs commented 1 year ago

implemented custom OSD position by adding extra field in line 1267

yuxiaolejs commented 1 year ago

@agsh

agsh commented 1 year ago

@yuxiaolejs Hi! Nice PR! Please just add also jsdoc to describe all possible parameters of position argument: https://github.com/yuxiaolejs/onvif/blob/2a803e33ab22f2a8cf04ab683db3863d27f1a3d6/lib/media.js#L1251

yuxiaolejs commented 1 year ago

@agsh Hi! I updated the docstring, and also changed it to strict equals. Have the code tested on my Hikvision DS-2CD3325-I IPC, everything worked as expected

agsh commented 1 year ago

@yuxiaolejs Cool! Should I put the updated version to NPM?

agsh commented 1 year ago

@yuxiaolejs Oh, and also fix lint errors, please: https://github.com/agsh/onvif/actions/runs/3729451314

yuxiaolejs commented 1 year ago

@yuxiaolejs Cool! Should I put the updated version to NPM?

I am glad to hear that! It's my pleasure to contribute to this project, and seeing it updated on NPM is great!

agsh commented 1 year ago

@yuxiaolejs Great! Just make a new PR with all of the changes please (I've reverted the merge because the linting pipeline broke) :) And I'll do the rest.