[feat] custom OSD position

agsh / onvif

ONVIF node.js implementation

http://agsh.github.io/onvif/

MIT License

681 stars 231 forks source link

[feat] custom OSD position #274

Closed yuxiaolejs closed 1 year ago

yuxiaolejs commented 1 year ago

[feat] custom OSD position [fix] typo in setOSD: videoSourceConfigurationToken

@agsh I fixed all the problems, really sorry for inconvience, this is my first time opening a PR, not really experienced. I tested the code using npm run lint and everything seemed to be fine.

agsh commented 1 year ago

It's ok, there is always a first time for doing something! :) Thanks!

agsh commented 1 year ago

Here it is: https://www.npmjs.com/package/onvif

yuxiaolejs commented 1 year ago

Thank you! I will continue to imporve myself!