search

agsh / onvif

ONVIF node.js implementation
http://agsh.github.io/onvif/
MIT License
679 stars 230 forks source link

Relax Token configuration check #288

Closed TA2k closed 1 year ago

TA2k commented 1 year ago

Any chance to merge this?

agsh commented 1 year ago

@TA2k Hello! Sure! Thanks!

RogerHardiman commented 1 year ago

I'd actually reject this commit. The reason is Names and Token ID are not related. So a Name could be "I am a Vide Source" and the Token can be "Tok001" So there is something else wrong if we are trying to match a name to a token. It is like trying to say someone's name is "1st January 1971"

Do you have any information on what is causing the problem. This could be some other media2 bug

RogerHardiman commented 1 year ago

oop, I remembered there was some XML pasted.

So the bug is elsewhere in Media2 and I don't understand enough of the Media2 API