agsh / onvif

ONVIF node.js implementation
https://onvif.pages.dev
MIT License
707 stars 240 forks source link

feat(onvif-events): Restart event requests after ECONNRESET error #320

Closed agsh closed 6 months ago

agsh commented 6 months ago

This is a compilation, refactoring and tests for two PRs about reconnecting if the connection to the device fails: https://github.com/agsh/onvif/pull/314 https://github.com/agsh/onvif/pull/319

cloudflare-workers-and-pages[bot] commented 6 months ago

Deploying onvif with  Cloudflare Pages  Cloudflare Pages

Latest commit: d04eae0
Status: ✅  Deploy successful!
Preview URL: https://792d14f7.onvif.pages.dev
Branch Preview URL: https://feat-restart-event-request-a.onvif.pages.dev

View logs

HarryEMartland commented 6 months ago

Yep that is looking good to me and is reconnecting to my doorbell after a restart.

Ill get an MR into Shinobi once the new version is available.

Thanks for your help with this!

agsh commented 6 months ago

@HarryEMartland You're welcome! :wink: Release is ready: https://github.com/agsh/onvif/actions/runs/9150337468