search

agsh / onvif

ONVIF node.js implementation
https://onvif.pages.dev
MIT License
703 stars 240 forks source link

GetScopes failed. #39

Closed bluet closed 8 years ago

bluet commented 8 years ago

I'm working on testing node-onvif with rpos https://github.com/BreeeZe/rpos I found that GetScopes failed. https://github.com/BreeeZe/rpos/issues/16

@RogerHardiman opened a PR fixing the problem https://github.com/agsh/onvif/pull/38

bluet commented 8 years ago

I've tested #38 and it works. Hope @agsh can merge it soon. :-)

RogerHardiman commented 8 years ago

Thanks for testing.I also found GetHostname had the same bug so fixed that too. All the other xml code looked fine.

In my office had one IP camera that accepted the bad xml (IPS Eye01) and two cameras that rejected the bad xml (axis m7001 and RPOS)

-------- Original message -------- From: BlueT - Matthew Lien - 練喆明 notifications@github.com Date:17/05/2016 5:46 AM (GMT+00:00) To: agsh/onvif onvif@noreply.github.com Cc: Roger Hardiman roger@rjh.org.uk,Mention mention@noreply.github.com Subject: Re: [agsh/onvif] GetScopes failed. (#39)

I've tested #38 and it works. Hope @agsh can merge it soon. :-)

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub

RogerHardiman commented 8 years ago

Merge of #38 is now complete