search

agsh / onvif

ONVIF node.js implementation
https://onvif.pages.dev
MIT License
703 stars 240 forks source link

Problem with discovery when a lan printer is in the network #78

Closed francesco-ismb closed 4 years ago

francesco-ismb commented 7 years ago

Hi,

I noticed that if some device, in my case a LAN printer, respond to a discovery request, the library doesn't check if that response message is onvif compliant. Then the library raise an exception when it try to create the cam object. I think it's enough adding a check here : https://github.com/agsh/onvif/blob/5cfed69389c5ba3eeef2a411f3ae1caf33119172/lib/discovery.js#L101

RogerHardiman commented 4 years ago

Hi @francesco-ismb Do you still have your LAN printer? i am interested in getting more details on the exception that is raised

chriswiggins commented 4 years ago

Closing out old issue