agsh / onvif

ONVIF node.js implementation
https://onvif.pages.dev
MIT License
703 stars 240 forks source link

Changes to PTZ + others (credit @hawkeye64) #86

Closed chriswiggins closed 6 years ago

chriswiggins commented 6 years ago

This is a squash of all the fantastic changes @hawkeye64 has provided

Remove old node versions from TravisCI testing Add gotoHomePosition and setHomePosition methods (with appropriate test suites) Fixes some camera’s fault parsing Bumps NPM package version, adds @hawekeye64 as contributor, fixes some npm deps Updates readme Updates test suite XML files to better naming convention

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-1.0%) to 86.916% when pulling e0e9415c608e5bf39544a92ccc8bbb4fa56e39e4 on chriswiggins:hawkeye64-changes into a21199c93b0f9d52387e0f368d3425ac6cb6dff6 on agsh:master.

chriswiggins commented 6 years ago

@agsh @hawkeye64 can you both please give this a once-over to make sure you're happy with it? I'll leave it open a week then merge if no complaints!

hawkeye64 commented 6 years ago

Looks good. I'll be able to test it Monday when I am at work and have access to all of our cameras.

hawkeye64 commented 6 years ago

This should read "+ * /PTZ/ Set home position"

hawkeye64 commented 6 years ago

Also, add yourself as a Contributor in package.json :)

chriswiggins commented 6 years ago

Ok thanks for spotting! I’ll sort tomorrow.

Can you flick me an email so we can collaborate on the snapshot module? I’ve done the initial commit and from what I can tell it works well but would like you to do some tests too?

hawkeye64 commented 6 years ago

How do I get your email? The message said you had replied with an email something-or-rather, and I clicked on it, which took me to your Github account. I didn't see anything there and when I came back, this message was gone. :(

edit:

Just refreshed and the message came back. Basically, it says "This comment left with email reply". How do I get your email?

edit: Figured it out. Email on the way.