Open nathanweeks opened 3 years ago
Hello,
I get the following warning on running liftoff. I think the tool works fine.... I have not checked the output thoroughly. However, just wanted to float this and reach out to see if others are facing any issues with this.
/mnt/common/rh6/annotate/Anaconda3/lib/python3.8/site-packages/Liftoff-1.6.3-py3.8.egg/liftoff/run_liftoff.py:45: SyntaxWarning: "is not" with a literal. Did you mean "!="?
/mnt/common/rh6/annotate/Anaconda3/lib/python3.8/site-packages/Liftoff-1.6.3-py3.8.egg/liftoff/run_liftoff.py:45: SyntaxWarning: "is not" with a literal. Did you mean "!="?
Thanks Abhijit
The use of
is not
with a string literal argument can result in a warning for Python versions >= 3.8https://github.com/agshumate/Liftoff/blob/8d1a6246296f0d7000442e16e4ae5ca0069a287f/liftoff/run_liftoff.py#L43
e.g., using the most recent Biocontainers build of liftoff 1.6.1 (using a Singularity image build):
Suggest using
!=
instead.An enlightening blog post on this topic: https://adamj.eu/tech/2020/01/21/why-does-python-3-8-syntaxwarning-for-is-literal/