agstrike / silverstrike

Finance Management Made Easy
https://silverstrike.org
MIT License
424 stars 100 forks source link

Add ability to use custom dateranges for account view (2) #55

Closed luisfmelo closed 6 years ago

simhnna commented 6 years ago

Besides the style errors, the custom daterange implies the ability to use user provided ranges, so we are going to need something like the daterangepicker.

We also need to have support for translation. I guess we can ignore momentjs for now, but the other strings should be translated.

luisfmelo commented 6 years ago

So, I need to put another option to use User provided date ranges?

simhnna commented 6 years ago

yeah much like the other merge request you opened. a dropdown with options to click right away and a button/link to show the rangepicker

Also don't be afraid to reuse merge requests. You can also use as many commits as you like, add and remove stuff. I can squash and merge in the end to cleanup intermediate state

luisfmelo commented 6 years ago

Flake command is failing, do you know why?

simhnna commented 6 years ago

because you changed to tox configuration. https://travis-ci.org/agstrike/silverstrike/jobs/353245563

simhnna commented 6 years ago

You have duplicated css and js files. Also please place them all in subdirectories of static/vendor

luisfmelo commented 6 years ago

@simhnna And How can I change to the correct configuration?

simhnna commented 6 years ago

Also please remove all changes to the base.html file. You don't need it and it contains an unprocessed git merge part

codecov-io commented 6 years ago

Codecov Report

Merging #55 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #55   +/-   ##
=======================================
  Coverage   73.71%   73.71%           
=======================================
  Files          21       21           
  Lines        1480     1480           
=======================================
  Hits         1091     1091           
  Misses        389      389

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f032632...1b320ff. Read the comment docs.

luisfmelo commented 6 years ago

@simhnna Can you see if it's ok now?

simhnna commented 6 years ago

merged it manually.

I added translation support, used minified versions and cleaned it up a little. Thanks for your contribution