agstudy / rsqlserver

Sql Server driver database interface (DBI) driver for R. This is a DBI-compliant Sql Server driver based on the System.Data.SqlClient.
82 stars 30 forks source link

releasing a minor update on local computer #40

Closed ghost closed 6 years ago

ghost commented 6 years ago

I am trying to test a minor update to rsqlserver locally, but am unsure what files I need to replace.

I compiled the project creating a new version of rsqlserver.net in rsqlserver-master\src.nocompile\rsqlserver.net\bin\Release and then I copied this to C:\Program Files\Microsoft\R Open\R-3.4.2\library\rsqlserver\libs

I am still getting an error message referring to C:\Users\Ruaridh Williamson\Documents\GitHub\rsqlserver\src.nocompile\rsqlserver.net\src\SqlDataHelper.cs, so I suspect that I need to replace some other file.

Do you have an idea what files I need to replace to release an update locally?

Thank you

ghost commented 6 years ago

never mind, with a larger search I found out the dll also had to be replaced in C:\Users\username\Documents\R\win-library\R_version_number\rsqlserver\libs instead

ruaridhw commented 6 years ago

Yes, that's right.

The dlls are included in the package pre-compiled in the inst/libs folder. My understanding is this isn't great practice and is why the error messages refers to source code hardcoded to my computer's path.

You've already worked this out but to recompile the entire package, you run xbuild on the .NET solution and then copy the dlls across to inst/libs before rebuilding the R package.

This used to be achieved with install.libs.R