search

agstudy / rsqlserver

Sql Server driver database interface (DBI) driver for R. This is a DBI-compliant Sql Server driver based on the System.Data.SqlClient.
82 stars 30 forks source link

Handle decimal and money types by converting to double #41

Closed ghost closed 6 years ago

ghost commented 6 years ago

Automatically convert decimal to double to workaround issue with decimal and money types without requiring casting in SQL code

ruaridhw commented 6 years ago

Thanks for the changes!

To contribute edits to existing files in the project it's best not to upload the files directly via GitHub but rather use a local copy of the repository and commit the changes to the files you want to edit followed by a push to your fork. Any changes to your fork branch sun0HnnN4475de8ZIZLG-patch-1 will automatically appear here.

What's happened is a new copy of SqlDataHelper.cs has been added to the top level directory when we actually want the existing copy (found at src.nocompile/rsqlserver.net/src/SqlDataHelper.cs) to be edited.

Does that help at all or would you like a bit more detail on how to make the edits locally?

ghost commented 6 years ago

Yes, I may need more detail on how to make the edits locally. I am going to start over since I messed up the path.