Add none option in Units picklist - Githubissues

agtzdimi / planet

PLANET Project

0 stars 0 forks source link

Add none option in Units picklist #70

Closed agtzdimi closed 4 years ago

agtzdimi commented 5 years ago

We need to add a none option in VES / P2G units in the tech-param component in order to let the user revert a selected flexibility Unit

agtzdimi commented 4 years ago

Maybe the else case in line 509 can be avoided as the this.paramInit['payload']['electric.grid'][this.displayingNode][unitType] will not be displayed anyway cause of the *ngIf. Fix also the comment in line 534

tsotakis commented 4 years ago

removing else case ngx-p2g-unit and ngx-ves-unit remain displayed even if we select none. Also "else case" i think its usefull in order to remove units parameters, if user has selected a unit before and then selects none.

agtzdimi commented 4 years ago

Yeap, in that case it's useful, let's keep it that way.

agtzdimi commented 4 years ago

Let's merge this one

agtzdimi commented 4 years ago

Issue merged to master, this can be closed

agtzdimi commented 4 years ago

When 'None' is used the Scenario's format is changed e.g if a P2G is used and then a user clicks 'None' the P2G attribute will be P2G: [] which will resolve an error at the simulation. For P2G none means 0 in nominal power

agtzdimi commented 4 years ago

To replicate the issue:

Add in function animateInfo inside case 3 in create-scenario.component.ts a console.log(this.paramInit)
The above function holds the JSON structure of a mandatory file for the simulation
Go to create a new scenario
Choose for first node a P2G unit
After that choose none and continue
The console should contain the JSON file. Look for the node.1: P2G attribute it should be

"P2G": { "nominal.electric.power": 0, "efficiency.electrolysis": 75, "efficiency.methanation": 80, "efficiency.thermal": 23, },

GeorgeGiannopoulos commented 4 years ago

The branch was merged to master Closing issue