search

agungprasetyosakti / ahastar

Automatically exported from code.google.com/p/ahastar
0 stars 0 forks source link

Move insertion and removal methods into HPAstar #11

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Inserting and removing start and goal nodes into the abstract graph is 
currently the responsibility 
of HPAClusterAbstraction. This is a legacy design that needs to be changed. 

Inserting is a pre-processing step we perform before running a search on the 
abstract graph so it 
should be dealt with by the class implementing HPA`*`

Original issue reported on code.google.com by dhara...@gmail.com on 16 Nov 2008 at 11:35

GoogleCodeExporter commented 9 years ago

Original comment by dhara...@gmail.com on 16 Nov 2008 at 11:35

GoogleCodeExporter commented 9 years ago 
This will require moving metrics stuff out of HPAClusterAbstraction and 
carefully measuring insertion effort via 
temporary variables in the insertion method.

Original comment by dhara...@gmail.com on 16 Nov 2008 at 12:02

GoogleCodeExporter commented 9 years ago 
HPACluster complicates this task significantly. 
All the logic to connect a node to its neighbours in the cluster is in this 
class and insertion relies on 
HPACluster::addNode. 

Two options exist:
1. Duplicate functionality from HPACluster (ugly; 2 sets of tests & 2 sets of 
maintenance headaches).
2. Move all the functionality out of HPACluster and into HPAStar2 (ugly also). 

Further complications also arise like how do differentiate between insertion 
and the pre-processing stages in 
a single method if we go with option2?

Original comment by dhara...@gmail.com on 17 Nov 2008 at 11:07

GoogleCodeExporter commented 9 years ago 
The introduction of InsertionPolicy in r810 addresses this issue. Different 
insertion policies can be passed to FlexibleAStar.

Still, this doesn't feel quite right. Insertion is specific to the type of 
abstraction being used. Probably insertion policy objects should be passed to 
mapAbstraction ctor as a parameter. 

Closing this. Opened Issue 35.

Original comment by dhara...@gmail.com on 7 Apr 2011 at 12:40

GoogleCodeExporter commented 9 years ago 
Wrong status previously. Fixed, but not exactly as specified.

Original comment by dhara...@gmail.com on 7 Apr 2011 at 12:56