Will cause stack overflow if included twice

agungprasetyosakti / js-hotkeys

Automatically exported from code.google.com/p/js-hotkeys

0 stars 0 forks source link

Will cause stack overflow if included twice #57

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago

Include the hotkeys script file twice. 

Attach an event that is not handled by hotkeys to any element. 

In IE the browser will crash. 

The reason is because jQuery.fn.bind is copied over to __bind__ twice and
therefore __bind__ ends up calling itself. 

This is not a bug since it can only be caused if you misuse the plug-in,
but it may be a worthy enhancement to make sure that __bind__ has not
already been set. 

http://julianjelfs.wordpress.com/2009/07/08/nasty-issue-sort-of-with-jquery-hotk
eys-plugin/

Original issue reported on code.google.com by julian.j...@googlemail.com on 8 Jul 2009 at 1:19

GoogleCodeExporter commented 8 years ago

thanks allot,
will add this fix immediately

Original comment by Afro.Sys...@gmail.com on 8 Jul 2009 at 1:26

Changed state: Started

GoogleCodeExporter commented 8 years ago

fix available at:
http://github.com/tzuryby/jquery.hotkeys/blob/4431c3a4c774ce986878ea504a4895c092
3463c2/jquery.hotkeys.js

Original comment by Afro.Sys...@gmail.com on 8 Jul 2009 at 1:34

Changed state: Fixed

GoogleCodeExporter commented 8 years ago

that's what I call service!

Original comment by julian.j...@googlemail.com on 8 Jul 2009 at 2:30

GoogleCodeExporter commented 8 years ago

the right link is this one
http://github.com/tzuryby/jquery.hotkeys/blob/502545e59556c296b1119f73eaad4aa0f9
e149c6/jquery.hotkeys.js

the previous will not work

Original comment by Afro.Sys...@gmail.com on 9 Jul 2009 at 3:02