search

agurod42 / github-texify

GitHub App to automatically render TeX expressions in markdown files
https://github.com/apps/texify
MIT License
110 stars 8 forks source link

TeXify emits improper HTML #13

Open leerho opened 4 years ago

leerho commented 4 years ago

HTML parameters must be enclosed in quotes ("). If they are not Jekyll will consider the entire image html to be text and it will not render properly. For example:

What TeXify emits:

What it needs to be:

GitHub (I think) uses Jekyll to render pages and sites. Even if there were a configuration to change Jekyll behavior, I would have access to the GitHub version of it.

I can reproduce this failure on my on laptop with using Jekyll locally.

Please fix this :) :)

leerho commented 4 years ago

Let me try this again but without the opening and closing brackets "<" and ">" so it won't try to render :)

What TeXify emits: <img src="/docs/Tuple/tex/4b83ab92144c8118c40653189ab60df5.svg?invert_in_darkmode&sanitize=true" align=middle width=81.54091274999998pt height=22.831056599999986pt/>

What it needs to be: <img src="/docs/Tuple/tex/4b83ab92144c8118c40653189ab60df5.svg?invert_in_darkmode&sanitize=true" align="middle" width="81.54091274999998pt" height="22.831056599999986pt"/&gt:

leerho commented 4 years ago

I substituted < and >

MrKaiWu commented 4 years ago

Same issue here. Please fix it, thanks!