agurod42 / github-texify

GitHub App to automatically render TeX expressions in markdown files
https://github.com/apps/texify
MIT License
110 stars 8 forks source link

Only files from the most recent commit in a push are rendered #2

Closed c-harding closed 6 years ago

c-harding commented 6 years ago

If two commits are made before a push, only the files modified in the most recent are modified.

https://github.com/agurodriguez/github-texify/blob/a5b703f1889ed1c8e397996e2bc6365ed04d7271/src/texify.js#L41

This should be solvable by replacing the above line with:

let commitFiles = [];
for (let commit of this.push.commits) {
    commitFiles.push(...commit.added, ...commit.modified);
}
c-harding commented 6 years ago

Awesome, thanks for all your work today

agurod42 commented 6 years ago

Yes, it is.

As far as I can see your request can’t be processed because we are receiving this error when trying to use Github API: HTTP/1.1 403 Forbidden Content-Type: application/json; charset=utf-8 Connection: close { "message": "You have triggered an abuse detection mechanism and have been temporarily blocked from content creation. Please retry your request again later.", "documentation_url": "https://developer.github.com/v3/#abuse-rate-limits" } https://developer.github.com/v3/#abuse-rate-limits

It’s probably because I generated a lot of request in the past hours when I was testing.

I’ll see if there is a better way to handle the requests in order to go through this limitation.

Sorry for the inconvenience

Regards,

Agustín Rodríguez http://agurodriguez.net

On May 9, 2018, at 12:27 PM, Charlie Harding notifications@github.com wrote:

Is the server running at the moment? I can't see any builds coming through at https://github.com/xsanda/SPS-notes/commits/master https://github.com/xsanda/SPS-notes/commits/master — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/agurodriguez/github-texify/issues/2#issuecomment-387778216, or mute the thread https://github.com/notifications/unsubscribe-auth/ANMlyWzsCdsgcLkGlyuxb7dDM5vdlS5Xks5twwrugaJpZM4T4FSj.